Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiohttp 3.10.2 #2158

Merged
merged 3 commits into from
Sep 3, 2024
Merged

aiohttp 3.10.2 #2158

merged 3 commits into from
Sep 3, 2024

Conversation

gandiddi
Copy link
Collaborator

@gandiddi gandiddi commented Aug 23, 2024 •
edited
Loading

@gandiddi gandiddi requested a review from a team as a code owner August 23, 2024 19:04
@gandiddi gandiddi requested a review from tracyboehrer August 23, 2024 19:07
@tracyboehrer
Copy link
Member

Failing PyLint with:

************* Module botbuilder-adapters-slack.botbuilder.adapters.slack.slack_client
libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py:420:8: E1701: Async context manager 'NoneType' doesn't implement aenter and aexit. (not-async-context-manager)

@gandiddi
Copy link
Collaborator Author

gandiddi commented Aug 28, 2024 •
edited
Loading

Failing PyLint with:

************* Module botbuilder-adapters-slack.botbuilder.adapters.slack.slack_client libraries/botbuilder-adapters-slack/botbuilder/adapters/slack/slack_client.py:420:8: E1701: Async context manager 'NoneType' doesn't implement aenter and aexit. (not-async-context-manager)

@tracyboehrer , I have verified pylint with both Python 3.10.11 and 3.9.13 and am not encountering the specified error locally. I am seeing the same results with and without the PR changes (the aiohttp version update in setup.py), as shown in the screenshot below.
image

@gandiddi gandiddi merged commit b802535 into main Sep 3, 2024
7 checks passed
@gandiddi gandiddi deleted the v-gandiddi/Bump_aiohttp branch September 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gandiddi @tracyboehrer